Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Create bot to comment in Gerrit when a wiki is created #285

Open
jhsoby opened this issue Apr 10, 2021 · 2 comments
Open

Create bot to comment in Gerrit when a wiki is created #285

jhsoby opened this issue Apr 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jhsoby
Copy link
Contributor

jhsoby commented Apr 10, 2021

The tool can leave comments in related Phabricator tasks when a patchdemo is created. It would be nice if it could leave comments on the patch itself in Gerrit as well.

@edg2s edg2s changed the title Comment in Gerrit when a patchdemo is created Create bot to comment in Gerrit when a wiki is created Apr 10, 2021
@edg2s edg2s added the enhancement New feature or request label Sep 29, 2021
@edg2s
Copy link
Collaborator

edg2s commented Mar 18, 2023

Upstream request:
https://phabricator.wikimedia.org/T332474

@hashar
Copy link
Contributor

hashar commented Mar 20, 2023

I have commented on the Phabricator task about adding the integration: https://phabricator.wikimedia.org/T332474#8708942

edg2s pushed a commit that referenced this issue May 24, 2023
We need the API to emit `Access-Control-Allow-Origin: *` to allow
downstream usage in JavaScript application. For example the integration
with https://gerrit.wikimedia.org/. Without it, the browser complains
with:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading
the remote resource at
https://patchdemo.wmflabs.org/api.php?action=findwikis&change=922162.
(Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

Part of #285
Follow-up #537

Bug: https://phabricator.wikimedia.org/T332474
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants