Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Add translate-manage right to admins #404

Closed
tacsipacsi opened this issue Dec 13, 2021 · 4 comments · Fixed by #406
Closed

Add translate-manage right to admins #404

tacsipacsi opened this issue Dec 13, 2021 · 4 comments · Fixed by #406
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tacsipacsi
Copy link
Contributor

Please add the translate-manage right to admins in extensions-Translate.php. I debugged on 51f093b25e quite a bit until I found out why I can’t see the new aggregate group form on Special:AggregateGroups… I can’t think of any negative effect of it except for making testing very orthopedic situations harder/impossible, but Patch Demo should aim at providing a usual environment, and this right is in the default right set for translation admins on Wikimedia.

@tacsipacsi
Copy link
Contributor Author

404 new aggregate group form not found. :)

@edg2s edg2s added enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2021
@edg2s
Copy link
Collaborator

edg2s commented Dec 14, 2021

I think you just need to add something like this

https://github.com/MatmaRex/patchdemo/blob/master/new/postinstall.sh#L35-L37

@tacsipacsi
Copy link
Contributor Author

Not even assigning an extra group needed, it’s enough to add $wgGroupPermissions['sysop']['translate-manage'] = true to the extension-specific PHP file I linked above. SecurePoll seems to query whether a user is part of the hardcoded electionadmin group instead of using a user right. Translate doesn’t do such silly things—in fact, translationadmin membership is not only not queried by the extension, this string isn’t even present in the codebase, it’s just a Wikimedia thing (for example, translatewiki.net has a transadmin group instead, with a different right set). So adding this group using the shell script wouldn’t make a difference (except for that maybe it causes an exception when one tries to add a nonexistent group?).

@edg2s
Copy link
Collaborator

edg2s commented Dec 14, 2021

If you submit a PR we can merge it

edg2s pushed a commit that referenced this issue Dec 14, 2021
This is needed for Special:AggregateGroups to allow modification.

Fixes #404
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants