This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Post links to Phabricator #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this locally with a key for my own account: https://phabricator.wikimedia.org/T265358#6539089 Just need to create a bot account and generate a key for it. |
edg2s
commented
Oct 13, 2020
| @@ -293,6 +293,26 @@ function set_progress( int $pc, string $label ) { | |||
| abandon( "Could not deduplicate." ); | |||
| } | |||
|
|
|||
| if ( count( $linkedTasks ) && $config['conduitApiKey'] ) { | |||
| set_progress( 95, 'Posting to Phabricator...' ); | |||
| $api = new \Phabricator\Phabricator( 'https://phabricator.wikimedia.org', $config['conduitApiKey'] ); | |||
There was a problem hiding this comment.
We should probably move our phab and gerrit URLs to config at some point.
|
Tested with PDBot's key: https://phabricator.wikimedia.org/T265358#6542530 and added that key to live config. |
|
New checkbox (selected by default): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144