Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory Click Event (event-item) #60

Closed
1 task done
RealRigBot opened this issue Aug 17, 2022 · 2 comments
Closed
1 task done

Inventory Click Event (event-item) #60

RealRigBot opened this issue Aug 17, 2022 · 2 comments
Labels
bug Something isn't working completed The issue has been resolved and the next update will apply requested changes priority : high Important features missing or bugs with a potentially high impact

Comments

@RealRigBot
Copy link

RealRigBot commented Aug 17, 2022 •
edited

Skript Version

image

Bug Description

on inventory click:
    broadcast "%event-item%"

This code works properly in all cases except when clicking on an empty slot.
When clicking on an empty slot the code stops running and this error is outputted:

[13:25:51 ERROR]: Could not pass event InventoryCreativeEvent to Skript v2.6.2
java.lang.AssertionError: null
        at ch.njol.skript.aliases.AliasesMap.matchAlias(AliasesMap.java:198) ~[?:?]
        at ch.njol.skript.aliases.AliasesProvider.getAliasData(AliasesProvider.java:349) ~[?:?]
        at ch.njol.skript.aliases.AliasesProvider.getMaterialName(AliasesProvider.java:367) ~[?:?]
        at ch.njol.skript.aliases.Aliases.getMaterialNameData(Aliases.java:186) ~[?:?]
        at ch.njol.skript.aliases.Aliases.getMaterialName(Aliases.java:190) ~[?:?]
        at ch.njol.skript.aliases.ItemData.toString(ItemData.java:274) ~[?:?]
        at ch.njol.skript.aliases.ItemType.toString(ItemType.java:1038) ~[?:?]
        at ch.njol.skript.aliases.ItemType.toString(ItemType.java:1004) ~[?:?]
        at ch.njol.skript.aliases.ItemType.toString(ItemType.java:1077) ~[?:?]
        at ch.njol.skript.classes.data.BukkitClasses$22.toString(BukkitClasses.java:1018) ~[?:?]
        at ch.njol.skript.classes.data.BukkitClasses$22.toString(BukkitClasses.java:998) ~[?:?]
        at ch.njol.skript.registrations.Classes.toString(Classes.java:618) ~[?:?]
        at ch.njol.skript.registrations.Classes.toString(Classes.java:647) ~[?:?]
        at ch.njol.skript.registrations.Classes.toString(Classes.java:640) ~[?:?]
        at ch.njol.skript.lang.VariableString.toString(VariableString.java:373) ~[?:?]
        at ch.njol.skript.lang.VariableString.getAll(VariableString.java:596) ~[?:?]
        at ch.njol.skript.effects.EffBroadcast.execute(EffBroadcast.java:93) ~[?:?]
        at ch.njol.skript.lang.Effect.run(Effect.java:50) ~[?:?]
        at ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:61) ~[?:?]
        at ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:89) ~[?:?]
        at ch.njol.skript.lang.Trigger.execute(Trigger.java:56) ~[?:?]
        at ch.njol.skript.SkriptEventHandler.check(SkriptEventHandler.java:142) ~[?:?]
        at ch.njol.skript.SkriptEventHandler.access$000(SkriptEventHandler.java:53) ~[?:?]
        at ch.njol.skript.SkriptEventHandler$PriorityListener.lambda$new$0(SkriptEventHandler.java:71) ~[?:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:74) ~[patched_1.8.8.jar:git-PaperSpigot-445]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.8.8.jar:git-PaperSpigot-445]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:517) [patched_1.8.8.jar:git-PaperSpigot-445]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:502) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1816) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PacketPlayInSetCreativeSlot.a(SourceFile:23) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PacketPlayInSetCreativeSlot.a(SourceFile:9) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [patched_1.8.8.jar:git-PaperSpigot-445]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_332]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_332]
        at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:774) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [patched_1.8.8.jar:git-PaperSpigot-445]
        at java.lang.Thread.run(Thread.java:750) [?:1.8.0_332]

Expected Behavior

The event-item was supposed to broadcast in chat.

Steps to Reproduce

on inventory click:
    broadcast "%event-item%"

Then simply click on an empty inventory slot!
Or you can go in your creative inventory and click items from there too!

Errors or Screenshots

[13:25:51 ERROR]: Could not pass event InventoryCreativeEvent to Skript v2.6.2
java.lang.AssertionError: null
        at ch.njol.skript.aliases.AliasesMap.matchAlias(AliasesMap.java:198) ~[?:?]
        at ch.njol.skript.aliases.AliasesProvider.getAliasData(AliasesProvider.java:349) ~[?:?]
        at ch.njol.skript.aliases.AliasesProvider.getMaterialName(AliasesProvider.java:367) ~[?:?]
        at ch.njol.skript.aliases.Aliases.getMaterialNameData(Aliases.java:186) ~[?:?]
        at ch.njol.skript.aliases.Aliases.getMaterialName(Aliases.java:190) ~[?:?]
        at ch.njol.skript.aliases.ItemData.toString(ItemData.java:274) ~[?:?]
        at ch.njol.skript.aliases.ItemType.toString(ItemType.java:1038) ~[?:?]
        at ch.njol.skript.aliases.ItemType.toString(ItemType.java:1004) ~[?:?]
        at ch.njol.skript.aliases.ItemType.toString(ItemType.java:1077) ~[?:?]
        at ch.njol.skript.classes.data.BukkitClasses$22.toString(BukkitClasses.java:1018) ~[?:?]
        at ch.njol.skript.classes.data.BukkitClasses$22.toString(BukkitClasses.java:998) ~[?:?]
        at ch.njol.skript.registrations.Classes.toString(Classes.java:618) ~[?:?]
        at ch.njol.skript.registrations.Classes.toString(Classes.java:647) ~[?:?]
        at ch.njol.skript.registrations.Classes.toString(Classes.java:640) ~[?:?]
        at ch.njol.skript.lang.VariableString.toString(VariableString.java:373) ~[?:?]
        at ch.njol.skript.lang.VariableString.getAll(VariableString.java:596) ~[?:?]
        at ch.njol.skript.effects.EffBroadcast.execute(EffBroadcast.java:93) ~[?:?]
        at ch.njol.skript.lang.Effect.run(Effect.java:50) ~[?:?]
        at ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:61) ~[?:?]
        at ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:89) ~[?:?]
        at ch.njol.skript.lang.Trigger.execute(Trigger.java:56) ~[?:?]
        at ch.njol.skript.SkriptEventHandler.check(SkriptEventHandler.java:142) ~[?:?]
        at ch.njol.skript.SkriptEventHandler.access$000(SkriptEventHandler.java:53) ~[?:?]
        at ch.njol.skript.SkriptEventHandler$PriorityListener.lambda$new$0(SkriptEventHandler.java:71) ~[?:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:74) ~[patched_1.8.8.jar:git-PaperSpigot-445]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.8.8.jar:git-PaperSpigot-445]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:517) [patched_1.8.8.jar:git-PaperSpigot-445]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:502) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1816) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PacketPlayInSetCreativeSlot.a(SourceFile:23) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PacketPlayInSetCreativeSlot.a(SourceFile:9) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [patched_1.8.8.jar:git-PaperSpigot-445]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_332]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_332]
        at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:774) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [patched_1.8.8.jar:git-PaperSpigot-445]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [patched_1.8.8.jar:git-PaperSpigot-445]
        at java.lang.Thread.run(Thread.java:750) [?:1.8.0_332]

Other

Nope!

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@RealRigBot
Copy link
Author

Update: event-slot seems to work fine but event-item is bugged. These both seem to do the same thing so I don't understand why event-item is a thing.

@Matocolotoe Matocolotoe added bug Something isn't working priority : high Important features missing or bugs with a potentially high impact labels Jan 8, 2023
@Matocolotoe Matocolotoe mentioned this issue Apr 25, 2023
Closed
1 task
Matocolotoe added a commit that referenced this issue Apr 25, 2023
@Matocolotoe
Attempt to fix huge errors with empty items (#60)
b01d015
@Matocolotoe
Copy link
Owner

Seems to be fixed now, at least the huge error doesn't appear anymore.
For comparisons with damageable items, the type of expression should be used.

@Matocolotoe Matocolotoe added the completed The issue has been resolved and the next update will apply requested changes label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working completed The issue has been resolved and the next update will apply requested changes priority : high Important features missing or bugs with a potentially high impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Matocolotoe @RealRigBot