Skip to content

Commit

Permalink
few tests
Browse files Browse the repository at this point in the history
  • Loading branch information
iilumme committed May 3, 2016
1 parent 48cc266 commit 7aee622
Show file tree
Hide file tree
Showing 4 changed files with 152 additions and 3 deletions.
16 changes: 16 additions & 0 deletions src/test/java/ohtuhatut/domain/ReferenceListTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,20 @@ public void gettingAndSettingReferencesWorks() {
assertTrue(list.getReferences().size() == 1);

}

@Test
public void removeReferenceMethodWorks() {

ReferenceList list = new ReferenceList();
List<Reference> references = new ArrayList<>();

BookletReference br = new BookletReference();
br.setTitle("test");
references.add(br);
list.setReferences(references);
assertTrue(list.getReferences().size() == 1);

list.removeReference(br);
assertTrue(list.getReferences().size() == 0);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public void swedishAIsFormatterProperly() {

ref.setKey("key1");
ref.setTitle("tÅtå");
ref.setYear(1999);
references.add(ref);

assertTrue(referenceFormatService.formatReferencesToBibTeX(references).contains("t{\\AA}t{\\aa}"));
Expand Down
109 changes: 109 additions & 0 deletions src/test/java/ohtuhatut/service/ReferenceListServiceTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
package ohtuhatut.service;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;

import ohtuhatut.Main;
import ohtuhatut.domain.BookletReference;
import ohtuhatut.domain.Reference;
import ohtuhatut.domain.ReferenceList;
import org.hibernate.Hibernate;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.SpringApplicationConfiguration;
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
import org.springframework.transaction.annotation.Transactional;


@RunWith(SpringJUnit4ClassRunner.class)
@SpringApplicationConfiguration(classes = Main.class)
public class ReferenceListServiceTest {

@Autowired
private ReferenceListService referenceListService;

@Autowired
private ReferenceService referenceService;

public ReferenceListServiceTest() {
}

@Transactional
@Test
public void removeReferenceMethodWorksCorrectly() {
ReferenceList list = new ReferenceList();
list.setName("test");
referenceListService.save(list);

BookletReference br = new BookletReference();
br.setKey("key");
br.setTitle("title");
referenceService.saveReference(br);
list.getReferences().add(br);

BookletReference br2 = new BookletReference();
br2.setKey("key2");
br2.setTitle("title2");
referenceService.saveReference(br2);
list.getReferences().add(br2);

BookletReference br3 = new BookletReference();
br3.setKey("key3");
br3.setTitle("title3");
referenceService.saveReference(br3);
list.getReferences().add(br3);

referenceListService.save(list);
assertTrue(list.getReferences().size() == 3);

referenceListService.removeReference(br);
assertTrue(list.getReferences().size() == 2);
assertFalse(list.getReferences().contains(br));

referenceService.deleteReference(br);
referenceService.deleteReference(br2);
referenceService.deleteReference(br3);

referenceListService.deleteReferenceList(list);
}

@Transactional
@Test
public void removeReferenceMethodDoesNotRemoveOtherReferences() {
ReferenceList list = new ReferenceList();
list.setName("test");
referenceListService.save(list);

BookletReference br = new BookletReference();
br.setKey("key");
br.setTitle("title");
referenceService.saveReference(br);
list.getReferences().add(br);

BookletReference br2 = new BookletReference();
br2.setKey("key2");
br2.setTitle("title2");
referenceService.saveReference(br2);
list.getReferences().add(br2);

BookletReference br3 = new BookletReference();
br3.setKey("key3");
br3.setTitle("title3");
referenceService.saveReference(br3);

referenceListService.save(list);
assertTrue(list.getReferences().size() == 2);

referenceListService.removeReference(br3);
assertTrue(list.getReferences().size() == 2);

referenceService.deleteReference(br);
referenceService.deleteReference(br2);
referenceService.deleteReference(br3);

referenceListService.deleteReferenceList(list);
}
}
29 changes: 26 additions & 3 deletions src/test/java/ohtuhatut/service/ReferenceServiceTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;

import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.SpringApplicationConfiguration;
Expand Down Expand Up @@ -282,15 +285,35 @@ public void whenKeyIsInUseBySomeOtherReferenceTheErrorMessageIsReturned() {
assertEquals("That key is in use on another reference, please use another key",
referenceService.keyIsInUseOnSomeOtherReferenceErrorMessage(ref2));
}

@Test
public void whenKeyIsNotInUseByAnyOtherReferenceNullIsReturned() {
Reference ref = new Reference();
ref.setKey("key9");

referenceService.saveReference(ref);

assertNull(referenceService.keyIsInUseOnSomeOtherReferenceErrorMessage(ref));
}


@Test
public void bindReferenceReturnsNullWhenTypeIsNotKnown() {
Reference ref = new Reference();
ref.setType("test");

Reference reference = referenceService.bindReference(ref);
assertNull(reference);
}

@Rule
public ExpectedException thrown = ExpectedException.none();

@Test
public void bindReferenceCausesNullPointerExceptionIfThereIsNoType() {
Reference ref = new Reference();
thrown.expect(NullPointerException.class);
Reference reference = referenceService.bindReference(ref);
}

}

0 comments on commit 7aee622

Please sign in to comment.