Merge pull request #23 from Matoking/iilumme

Add some tests
Matoking · Apr 19, 2016 · 82e5ace · 82e5ace
2 parents 4f4a8d3 + 450136f
commit 82e5ace
Show file tree

Hide file tree

Showing 4 changed files with 145 additions and 0 deletions.
diff --git a/pom.xml b/pom.xml
@@ -150,6 +150,11 @@
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
                 <version>0.7.5.201505241946</version>
+                <configuration>
+                    <excludes>
+                        <exclude>**/**/ProductionProfile.class</exclude>
+                    </excludes>
+                </configuration>
                 <executions>
                     <execution>
                         <id>prepare-agent</id>

diff --git a/src/test/java/ohtuhatut/controller/ReferenceControllerTest.java b/src/test/java/ohtuhatut/controller/ReferenceControllerTest.java
@@ -106,6 +106,18 @@ public void postRequestToBookreferencesNewSavesABookreferenceToDatabase() throws
 
     }
 
+    @Test
+    public void postToCreateNotValidBookreferenceDoesNotSave() throws Exception {
+
+        mockMvc.perform(post(API_URI + "/bookreferences/new")
+                .param("title", "test")
+                .param("publisher", "testingplace")
+                .param("year", "2016"));
+
+        assertTrue(bookReferenceRepository.count() == 0);
+
+    }
+
 
     @Test
     public void getRequestToCreateANewArticleReferenceWorks() throws Exception {
@@ -132,6 +144,19 @@ public void postRequestToArticlereferencesNewSavesAArticlereferenceToDatabase()
 
     }
 
+    @Test
+    public void postToCreateNotValidArticlereferenceDoesNotSave() throws Exception {
+
+        mockMvc.perform(post(API_URI + "/articlereferences/new")
+                .param("title", "test")
+                .param("journal", "testingplace")
+                .param("volume","1")
+                .param("year", "2016"));
+
+        assertTrue(articleReferenceRepository.count() == 0);
+
+    }
+
     @Test
     public void getRequestToCreateANewBookletReferenceWorks() throws Exception {
 
@@ -153,6 +178,15 @@ public void postRequestToBookletreferencesNewSavesABookletreferenceToDatabase()
 
     }
 
+    @Test
+    public void postToCreateNotValidBookletreferenceDoesNotSave() throws Exception {
+
+        mockMvc.perform(post(API_URI + "/bookletreferences/new"));
+
+        assertTrue(bookletReferenceRepository.count() == 0);
+
+    }
+
     @Test
     public void getRequestToCreateANewManualReferenceWorks() throws Exception {
 
@@ -174,6 +208,16 @@ public void postRequestToManualreferencesNewSavesAManualreferenceToDatabase() th
 
     }
 
+    @Test
+    public void postToCreateNotValidManualreferenceDoesNotSave() throws Exception {
+
+        mockMvc.perform(post(API_URI + "/manualreferences/new"));
+
+        assertTrue(manualReferenceRepository.count() == 0);
+
+    }
+
+
 }
 
 

diff --git a/src/test/java/ohtuhatut/domain/ReferenceListTest.java b/src/test/java/ohtuhatut/domain/ReferenceListTest.java
@@ -0,0 +1,36 @@
+package ohtuhatut.domain;
+
+import org.junit.Before;
+import org.junit.Test;
+import static org.junit.Assert.assertTrue;
+import java.util.ArrayList;
+import java.util.List;
+
+public class ReferenceListTest {
+
+    @Test
+    public void gettingAndSettingNameWorks() {
+        ReferenceList list = new ReferenceList();
+        list.setName("test");
+
+        assertTrue(list.getName().equals("test"));
+    }
+
+    @Test
+    public void gettingAndSettingReferencesWorks() {
+
+        ReferenceList list = new ReferenceList();
+        List<Reference> references = new ArrayList<>();
+
+        BookletReference br = new BookletReference();
+        br.setTitle("test");
+        references.add(br);
+
+        assertTrue(list.getReferences().size() == 0);
+
+
+        list.setReferences(references);
+        assertTrue(list.getReferences().size() == 1);
+
+    }
+}
diff --git a/src/test/java/ohtuhatut/domain/ReferenceTest.java b/src/test/java/ohtuhatut/domain/ReferenceTest.java
@@ -3,6 +3,9 @@
 import static org.junit.Assert.assertTrue;
 import org.junit.Test;
 
+import java.util.ArrayList;
+import java.util.List;
+
 /**
  *
  * @author tuomokar
@@ -33,4 +36,61 @@ public void gettingEmptyFieldsWorksWhenAllFieldsAreEmpty() {
 
     }
 
+    @Test
+    public void gettingFieldWhichIsNotAFieldOfTheReference() {
+        Reference ref = new BookletReference();
+        assertTrue(ref.getField("author") == null);
+        assertTrue(ref.getField("publisher") == null);
+        assertTrue(ref.getField("moon") == null);
+    }
+
+    @Test
+    public void gettingMandatoryFieldsWorks() {
+        Reference ref = new BookReference();
+
+        assertTrue(ref.getMandatoryFields().size() == 4);
+        assertTrue(ref.getMandatoryFields().contains("author"));
+        assertTrue(ref.getMandatoryFields().contains("title"));
+        assertTrue(ref.getMandatoryFields().contains("publisher"));
+        assertTrue(ref.getMandatoryFields().contains("year"));
+    }
+
+    @Test
+    public void settingMandatoryFieldsWorks() {
+        Reference ref = new BookletReference();
+        List<String> fields = new ArrayList<>();
+
+        fields.add("testField");
+        ref.setMandatoryFields(fields);
+
+        assertTrue(ref.getMandatoryFields().size() == 1);
+        assertTrue(ref.getMandatoryFields().contains("testField"));
+    }
+
+    @Test
+    public void gettingAndSettingOptionalFieldsWorks() {
+
+        Reference ref = new BookletReference();
+        List<String> fields = new ArrayList<>();
+
+        fields.add("testField");
+        ref.setOptionalFields(fields);
+
+        assertTrue(ref.getOptionalFields().size() == 1);
+        assertTrue(ref.getOptionalFields().contains("testField"));
+
+    }
+
+    @Test
+    public void settingFieldsWorks() {
+        Reference ref = new BookletReference();
+        List<String> fields = new ArrayList<>();
+
+        fields.add("testField");
+        ref.setFields(fields);
+
+        assertTrue(ref.getFields().size() == 1);
+        assertTrue(ref.getFields().contains("testField"));
+    }
+
 }