Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added special characters to reference formatting #45

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Conversation

sofiak
Copy link
Collaborator

@sofiak sofiak commented Apr 26, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 92.915% when pulling 7605685 on sofiak into cc0f20d on master.

@tuomokar
Copy link
Collaborator

Did you test this? I'm fairly sure this doesn't work correctly. String is immutable so calling the method replaceSpecialCharactersToBibtex without assigning the returned string to 'value' variable shouldn't do anything. Two other things too: The \ escapes and makes it possible for the quotation marks to be used, but if I understood correctly from quickly reading Bibtex docs (I might be wrong though), it needs a backslash to be in the bibtex file too. So using only one backslash isn't enough, but in the method there needs 3 of them (one to escape the quotation mark, one to be actually shown in the string, and one to escape that blackslash) so that they go to the bibtex file correctly .\r also causes a line change which I'd guess isn't quite the correct one to use for the letter å.

But that's alright. Since we have the client meeting quite soon I'll merge, make the necessary fixes (you have the right idea there so fixes are pretty small) and write some tests to make sure it works.

@tuomokar tuomokar merged commit abd6533 into master Apr 27, 2016
@tuomokar
Copy link
Collaborator

Taking my words back a little (having discussed with you elsewhere). You can fix it later and we'll confirm in the client meeting how it's supposed to go, since there seems to be a little bit of conflicting information on the special letters (for example BibTex.org vs LaTeX Stack Exchange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants