Fix Python 3.4 compatibility

Both setup.py and README state this application is Python 3.4
compatible. Python 3.4 is EOL, but the issues are easy enough to fix.

.travis.yml

@@ -7,6 +7,7 @@ matrix:
       sudo: true
     - python: "3.6"
     - python: "3.5"
+    - python: "3.4"
 install:
   - pip install .
   - pip install -r requirements_dev.txt

src/protontricks/gui.py

@@ -1,6 +1,6 @@
 import logging
 import sys
-from subprocess import run, PIPE, CalledProcessError
+from subprocess import check_output, PIPE, CalledProcessError
 
 __all__ = ("select_steam_app_with_gui",)
 
@@ -20,12 +20,11 @@ def select_steam_app_with_gui(steam_apps):
     ])
 
     try:
-        result = run([
+        choice = check_output([
             'zenity', '--forms', '--text=Steam Game Library',
             '--title=Choose Game', '--add-combo', 'Pick a library game',
             '--combo-values', combo_values
         ], check=True, stdout=PIPE, stderr=PIPE)
-        choice = result.stdout
     except CalledProcessError as exc:
         # TODO: Remove this hack once the bug has been fixed upstream
         # Newer versions of zenity have a bug that causes long dropdown choice

src/protontricks/util.py

@@ -1,6 +1,6 @@
 import logging
 import os
-from subprocess import run, check_output
+from subprocess import call, check_output
 
 __all__ = ("run_command",)
 
@@ -81,7 +81,7 @@ def get_runtime_library_path(steam_runtime_path, proton_app):
     logger.info("Attempting to run command %s", command)
 
     try:
-        run(command, **kwargs)
+        call(command, **kwargs)
     finally:
         # Restore original env vars
         os.environ.clear()

tests/conftest.py

@@ -477,11 +477,6 @@ def __init__(self, args=None, kwargs=None, mock_stdout=None, env=None):
         self.env = env
 
 
-class MockResult:
-    def __init__(self, stdout):
-        self.stdout = stdout
-
-
 @pytest.fixture(scope="function", autouse=True)
 def zenity(monkeypatch):
     """
@@ -490,15 +485,15 @@ def zenity(monkeypatch):
     """
     mock_zenity = MockSubprocess()
 
-    def mock_subprocess_run(args, **kwargs):
+    def mock_subprocess_check_output(args, **kwargs):
         mock_zenity.args = args
         mock_zenity.kwargs = kwargs
 
-        return MockResult(stdout=mock_zenity.mock_stdout.encode("utf-8"))
+        return mock_zenity.mock_stdout.encode("utf-8")
 
     monkeypatch.setattr(
-        "protontricks.gui.run",
-        mock_subprocess_run
+        "protontricks.gui.check_output",
+        mock_subprocess_check_output
     )
 
     yield mock_zenity
@@ -512,16 +507,16 @@ def command(monkeypatch):
     """
     mock_command = MockSubprocess()
 
-    def mock_subprocess_run(args, **kwargs):
+    def mock_subprocess_call(args, **kwargs):
         mock_command.args = args
         mock_command.kwargs = kwargs
         mock_command.env = os.environ.copy()
 
-        return MockResult(stdout=b"")
+        return 0
 
     monkeypatch.setattr(
-        "protontricks.util.run",
-        mock_subprocess_run
+        "protontricks.util.call",
+        mock_subprocess_call
     )
 
     yield mock_command

tests/test_gui.py

@@ -11,7 +11,7 @@ def broken_zenity(zenity, monkeypatch):
     the following GitHub issue:
     https://github.com/Matoking/protontricks/issues/20
     """
-    def mock_subprocess_run(args, **kwargs):
+    def mock_subprocess_check_output(args, **kwargs):
         zenity.args = args
 
         raise CalledProcessError(
@@ -22,8 +22,8 @@ def mock_subprocess_run(args, **kwargs):
         )
 
     monkeypatch.setattr(
-        "protontricks.gui.run",
-        mock_subprocess_run
+        "protontricks.gui.check_output",
+        mock_subprocess_check_output
     )
 
     yield zenity