Add grpc server #47
Closed
Add grpc server #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zachaccino can you have a look at this regarding GRPC. @robert-cronin can you point to which specific file has the GRPC implementation? |
|
The specific files that have gRPC are git_server.proto, PeerManager.ts:Line98 and GitClient.ts. Any insights you could share would be appreciated, I've only had limited experience with using gRPC in production. I also am still yet to figure out the best way to implement the secure credentials for SSL mostly the CA. |
|
Looks good to me, that said, I don't have much experience working with GRPC in production either. |
Merged
|
This PR is closed in favour of PR #52 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is specifically for making the git backend use GRPC for secure communications.
Fixes #46.