Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node20 and switch pkg #111

Closed
tegefaulkes opened this issue Jan 30, 2024 · 7 comments · Fixed by #137
Closed

Update to Node20 and switch pkg #111

tegefaulkes opened this issue Jan 30, 2024 · 7 comments · Fixed by #137
Assignees
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

Specification

There are two parts to this issue.

  1. Once again updating to node 20 as it's supported by the packager now.
  2. Switch the packager from vercel/pkg to https://github.com/yao-pkg/pkg

Additional context

Related #40 (comment)

Tasks

  1. Update to node 20
  2. switch to using yao-pkg/pkg for packaging. This includes removing the use of vercel/pkg.
@tegefaulkes tegefaulkes added the development Standard development label Jan 30, 2024
@CMCDragonkai CMCDragonkai mentioned this issue Feb 15, 2024
15 tasks
@CMCDragonkai
Copy link
Member

When switching to node 20 and the new yao pkg, enable the arm64 builds. It's now available. See: https://github.com/yao-pkg/pkg-fetch/releases

Will need to update utils.nix and .gitlab-ci.yml to produce those builds. Also this infrastructure should be moved to nixpkgs-matrix so we can use it across multiple projects.

@CMCDragonkai
Copy link
Member

PK is already on Node 20. This should be part of the #40.

@CMCDragonkai
Copy link
Member

Node 20 is LTS since october last year.

@amydevs
Copy link
Member

amydevs commented Feb 22, 2024

This seems to have already been done.

enable the arm64 builds

We will need to make arm64 builds for the dependencies before this can happen (js-db, js-mdns, etc.)

@amydevs amydevs closed this as completed Feb 22, 2024
@CMCDragonkai
Copy link
Member

This is done? Where's the PR.

@amydevs
Copy link
Member

amydevs commented Feb 22, 2024

pretty sure the switch to yao-pkg was done in 2ef4aa9

@amydevs amydevs reopened this Feb 22, 2024
@amydevs
Copy link
Member

amydevs commented Feb 22, 2024

ah wait, the environment scripts and the flake still refer to node 18, will switch it over

@amydevs amydevs mentioned this issue Feb 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

Successfully merging a pull request may close this issue.

3 participants