Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit CLI commands for inspecting audit event history #177

Closed
tegefaulkes opened this issue Apr 26, 2024 · 3 comments · Fixed by #178
Closed

Audit CLI commands for inspecting audit event history #177

tegefaulkes opened this issue Apr 26, 2024 · 3 comments · Fixed by #178
Assignees
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

Specification

The Audit domain was added to the Polykey library and is being used for the polykey website dashboard. But we haven't yet exposed it to the CLI. It will be useful for auditing connection and discovery events. But also any other types of events when they are added into the audit domain.

The audit command will be generic to handling all kinds of audit events. Event types to iterate over will be selected by the event path. We should allow the ability to specify multiple paths as a varidic in a dot path format of a.b.c. It will be possible to specify a subpath, parent path or duplicate paths at the same time so we'll need to trim the list to the minimal relevant paths. A union of a duplicate is the same path, A union of a child and parent path is just the parent path.

When iterating over the multiple paths we're going to use a iterator zipper method. Where each path has it's own iterator. Each select from each iterator to be read from based on the strict ordering of the AuditEventId which is a monotonic logical ordering based on time.

Further features and formatting needs to be specced out.

Additional context

Tasks

  1. expand this spec.
@tegefaulkes tegefaulkes added the development Standard development label Apr 26, 2024
@tegefaulkes tegefaulkes self-assigned this Apr 26, 2024
Copy link

linear bot commented Apr 26, 2024

@tegefaulkes tegefaulkes removed their assignment Apr 26, 2024
@tegefaulkes tegefaulkes mentioned this issue Apr 26, 2024
9 tasks
@tegefaulkes tegefaulkes self-assigned this Apr 26, 2024
@tegefaulkes tegefaulkes assigned amydevs and unassigned tegefaulkes May 3, 2024
Copy link
Contributor Author

@amydevs is going to take this issue over.

@CMCDragonkai CMCDragonkai changed the title Create audit domain for inspecting audit event history Create audit CLI commands for inspecting audit event history May 12, 2024
@amydevs amydevs changed the title Create audit CLI commands for inspecting audit event history Audit CLI commands for inspecting audit event history May 12, 2024
@tegefaulkes tegefaulkes assigned tegefaulkes and unassigned amydevs May 26, 2024
Copy link
Contributor Author

Right now this is blocked by an issue in PKNS https://github.com/MatrixAI/Polykey-Network-Status/issues/2 That in itself is kind of blocked by CI fixes @brynblack is working on. That said, going ahead we can do a manual deployment just to move forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

Successfully merging a pull request may close this issue.

2 participants