Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Commits for Vault Changes #16

Closed
CMCDragonkai opened this issue Jan 23, 2019 · 1 comment · Fixed by #43
Closed

Automatic Commits for Vault Changes #16

CMCDragonkai opened this issue Jan 23, 2019 · 1 comment · Fixed by #43
Assignees
Labels
development Standard development

Comments

@CMCDragonkai
Copy link
Member

Changes to any vault should involve an automatic commit to our Git version control system.

We should try to make this system write sensible messages. And we need to carefully manage the Git commit history and consider issues like diverging histories and merge strategies dealing with incompatible histories. We need to make this as automatic as possible so that end-users do not have to do a manual merge like they would for source control.

Issue regarding redundant commit messages: #5 - we may need to be able to transactionally modify things. So edits to multiple files should be 1 commit if they represent the same change in secrets.

Initial experiment here: aa8d4ae

@CMCDragonkai CMCDragonkai added the development Standard development label Jan 23, 2019
@CMCDragonkai CMCDragonkai changed the title Automatic Commits Automatic Commits for Vault Changes Jan 23, 2019
@robert-cronin
Copy link
Contributor

robert-cronin commented Jun 5, 2020

Automatic commits will be implemented in the upcoming PR #43, however they still do not address the case of multiple files changed at once since polykey simply does not allow one to modify multiple secrets at once. A commit is made for every action currently possible (addSecret, removeSecret and updateSecret which I have added as a part of the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

Successfully merging a pull request may close this issue.

3 participants