Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of domains without networking for bootstrapping #539

Open
tegefaulkes opened this issue Aug 1, 2023 · 2 comments
Open

Allow creation of domains without networking for bootstrapping #539

tegefaulkes opened this issue Aug 1, 2023 · 2 comments
Labels
development Standard development

Comments

@tegefaulkes
Copy link
Contributor

Specification

For bootstrapping we want to set up Polykey state without starting up networking or attempting network discovery. To do this we just need to create and start domains that use and modify the DB as well as others. Some of these depend on networking code so to streamline this we need the ability to create some domains without providing networking as a dependency.

Alternatively, we can extract all of the state creation to utility functions and call only those in bootstrapping.

Additional context

Tasks

  1. streamline the bootstrapping process.
  2. Avoid depending on networking domains when doing bootstrapping.
  3. Avoid any typescript hacks such as as any or as domain.
@tegefaulkes tegefaulkes added the development Standard development label Aug 1, 2023
@tegefaulkes
Copy link
Contributor Author

The creation of the NodeConnectionManger in bootstrapping has been removed. Any dependency of NodeConnectionManager has been replaced with {} as any.

@CMCDragonkai
Copy link
Member

This requires some thinking, especially in relation to an IoC container, as well as dealing with destroy after stop.

I think the issue right now is that certain dependencies are being needed for certain side effects. If those side effects could be done without needing those dependencies, it would probably work better.

Should be thought about in relation to #442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

2 participants