Rework Id creation to check statically for invalid IDs #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
enhancement
api-break
mbunkus
requested changes
Jan 28, 2024
ebml/EbmlId.h
Outdated
| return Value >= 0x4000; | ||
| if (Value < 0x1000000) | ||
| return Value >= 0x200000; | ||
| return Value >= 0x10000000; |
There was a problem hiding this comment.
Wrong indentation for the last return.
There was a problem hiding this comment.
Fixed. I'll rebase the branches soon.
It's a 32-bit value, there's only 4 possible lengths.
In C++17 that implies "inline".
It's deduced during contruction.
An EbmlId can never be bigger that 4. There is no constructor with a value higher than 4 bytes. It can never be lower than 0 as it's unsigned. It can never be 0 because a value of 0 corresponds to 0x80 in EBML.
When we have a buffer we can convert it to an Id value.
mbunkus
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it's possible with std::enable_if but I haven't managed to do it. Not sure it would be usable on reading though.
We don't need to pass the length of the ID anymore (we may not even store it anymore).
libmatroska will need this to build Matroska-Org/libmatroska#169