fix: RunGuard not works on Qt6 #1095
Merged
+5
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 32ef100.
|
Amiraliad |
bygreencn
added a commit
to bygreencn/nk-win7
that referenced
this pull request
Jul 18, 2024
* tag '3.26': 3.26 fix: MatsuriDayo#1024 fix: RunGuard not works on Qt6 (MatsuriDayo#1095)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前的32ef100 修复有问题，会造成#1088，此提交修复#1088 并重新修复#955 。
PS: #1089 猜测有可能也是由于这个原因，具体需要有Windows环境的人进行测试。
The previous fix 32ef100 has issue, causing problem #1088, This commit addresses and resolves #1088, as well as re-fixes #955.
P.S.: It is speculated that #1089 might also be related to the same issue. Testing is needed from someone with a Windows environment.