Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matt,
Many thanks for this package! I've used it in all kinds of projects. I really, really like the approach.
This tiny PR fixes the license metadata in
package.json
to conform to npm's guidelines. Fair is fair: I was involved in writing those guidelines. The idea is to make it easy to automate license checks even for really deepnode_modules
directories. Running an automatic tool is exactly what tipped me off abouthttp-hash
.The old
licenses
Array was definitely a thing in the early days of node, which took a lot from RubyGems. I believe the original CommonJS spec actually mentioned it. For various reasons, it's turned out to be noisier and less expressive than proper SPDX (license metadata standard) expressions.I can't answer legal questions, but if you have any questions about metadata or the npm guidelines, feel free to hit me up.
Again, thanks very much for the package!
Best,
K