Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm-standard license metadata #5

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

kemitchell
Copy link
Contributor

Matt,

Many thanks for this package! I've used it in all kinds of projects. I really, really like the approach.

This tiny PR fixes the license metadata in package.json to conform to npm's guidelines. Fair is fair: I was involved in writing those guidelines. The idea is to make it easy to automate license checks even for really deep node_modules directories. Running an automatic tool is exactly what tipped me off about http-hash.

The old licenses Array was definitely a thing in the early days of node, which took a lot from RubyGems. I believe the original CommonJS spec actually mentioned it. For various reasons, it's turned out to be noisier and less expressive than proper SPDX (license metadata standard) expressions.

I can't answer legal questions, but if you have any questions about metadata or the npm guidelines, feel free to hit me up.

Again, thanks very much for the package!

Best,

K

@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling c2cc77d on kemitchell:standard-license-metadata into 6e4bafe on Matt-Esch:master.

@Matt-Esch Matt-Esch merged commit 9a76017 into Matt-Esch:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants