Serverside music #608
Merged
Serverside music #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Music is now played serverside, meaning that other players can hear the music inside the TARDIS.
Changed some things around to keep it future-proof for any further changes to the music screen.
I forgot to move one line over to the networked message
- merged cl_music and sv_music into sh_music - only network music stop when explicitly pressing stop - fix error when pressing play with no music selected - remove unneeded function in SendMessage call - removed unnecessary PlayerEnter hook - added option for music to stop on exit
MattJeanes
approved these changes
Feb 3, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to the music system to make it serverside - meaning others can hear what you are listening to.
Closes #322