Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill plugin #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arashm
Copy link

@arashm arashm commented Nov 2, 2016

This commit adds a new plugin to darkroom which is similar to crop. It allows you to select an area and fill the area black. Useful for when you want to censor a part of the picture.
This is probably not the best production level code, but it works. I tried to avoid making duplicate codes and moved most of the parts related to selecting an area to another plugin so both crop and fill uses the same code. I just leave it here for others who may need similar functionality. If merged, others will have the opportunity to make it better.

@Asuza
Copy link

Asuza commented Dec 5, 2016

@arashm, thank you for providing this pull request. It gave me a great head start on implementing my own fill functionality. The main difference being that I want the fill to work immediately, rather than having to select and confirm an area.

@Asuza Asuza mentioned this pull request Dec 5, 2016
@phuicy
Copy link

phuicy commented Jan 28, 2018

Amazing, this is exactly what I was looking for.

@MattKetmo MattKetmo force-pushed the master branch 2 times, most recently from f2f6a0a to cd086fe Compare July 8, 2021 12:23
Repository owner deleted a comment from 331leo Jan 29, 2024
Repository owner deleted a comment from 19890843006 Feb 19, 2024
Repository owner deleted a comment Mar 1, 2024
Repository owner deleted a comment Mar 1, 2024
Repository owner deleted a comment from naudachu Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants