Containerization, Class Restructuring, Lint Fixes, Module Export Changes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add containerization using Inversify - Restructure to optimize Classes and Tests - Fix tslint configuration - Fix various lint errors and warnings - Move retry logic to utils function - Move Cloud Config Client call to separate gateway class - Move Cloud Config Client retrieval logic to separate service class - Hide internal implementation behind private methods - Move test logic for private functions to the 'load' function tests
Pull Request Test Coverage Report for Build 190
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 190
💛 - Coveralls |
MattRoss34
added a commit
that referenced
this pull request
Jul 11, 2019
…ges (#38) * Containerize, Restructure Classes, Lint Fixes - Add containerization using Inversify - Restructure to optimize Classes and Tests - Fix tslint configuration - Fix various lint errors and warnings - Move retry logic to utils function - Move Cloud Config Client call to separate gateway class - Move Cloud Config Client retrieval logic to separate service class - Hide internal implementation behind private methods - Move test logic for private functions to the 'load' function tests * Add Config export for TypeScript, tests for index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerize, Restructure Classes, Lint Fixes, Module Export Changes