Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev - MainViewActivity Overhaul #22

Open
MattS8 opened this issue Aug 24, 2019 · 0 comments
Open

dev - MainViewActivity Overhaul #22

MattS8 opened this issue Aug 24, 2019 · 0 comments
Assignees
@MattS8
Labels
android Related to android application. under-development

Comments

@MattS8
Copy link
Owner

MattS8 commented Aug 24, 2019

Restructuring the logic in MainViewActivity. Very clean! Much nice!
@MattS8 MattS8 self-assigned this Aug 24, 2019
@MattS8 MattS8 added android Related to android application. under-development labels Aug 24, 2019
MattS8 added a commit that referenced this issue Aug 24, 2019
@MattS8
Android - #22, Misc
052d36a 
- Begun, the overhaul has
- Adding state variables into the Activity itself
    - This allows for custom setters which automagically trigger state updates for the other views
- new LayoutState encompasses the primary 'states' the main view can find itself  in
- Removed unnecessary code from MainViewAdapter

- Added 'unknown save error' flashbar generator (found in Remote model)
- Added 'generic coming soon' flashbar generator (found in ActivityExt utils)
MattS8 added a commit that referenced this issue Aug 24, 2019
@MattS8
Android - #22, Misc
663aa36 
- Made 'State' read-only
    - all state variables are held within the activity so they can be properly observed

- Fixed GenericCoomingSoonFlashbar (added message string)
MattS8 added a commit that referenced this issue Aug 24, 2019
@MattS8
Android - #22, #6
940bc2d 
- Moved remote creation into a new 'RemoteCreator' class
MattS8 added a commit that referenced this issue Nov 22, 2019
@MattS8
Android - #6, #17, #23, #22
9c7f2d4 
#6
- RemoteCreator reworked to more closely resemble the structure of other 'creator' modules
- Now contains a context reference
- Keeps track of it's visibility in its own state now

#17
RemoteLayout
- Setting the binding reference now properly updates the internal button creator and sets up the adapters
- Now contains the 'topPadding' value to set for the remote layout
- Lots of the logic regarding updating the layout have been moved to this class (i.e. 'edit mode' listener, 'add button' listener, 'button creation process complete' listener)

#23
CommandCreator
- Now 'resets' many of the internal variables to their default state when the dialog is dismissed. Since dismissing the dialog is only done when a user completely backs out or finishes a process now, this is a viable solution to resetting the creator for further use.
- Fixed a bug where instructionsBinding and newCommandSheetBinding weren't set to null upon removing the context reference
- Fixed a bug where 'showActionsFromDialog()' wasn't using the new 'createDialog()' function

#22
- The button creator was removed and is now found within the RemoteLayout variable
- The state variables 'isShowingCreateRemoteView' and 'isShowingCreateButtonView' have been removed as they are now unnecessary
-  Removed several listeneners which are now found within the RemoteLayout class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattS8 MattS8

Labels
android Related to android application. under-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MattS8