Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add or update type hints #82
Add or update type hints #82
Changes from 10 commits
352e1d5
166666e
94990c7
a217d2e
5fd8d22
0af605b
21c2787
195ea56
2d9a507
22ca436
03f398b
8cf6b01
42dd6d8
bc2e471
7f75d31
bfc48de
14b7f82
9f79740
865ed60
a1bd8cf
90266df
04da88c
f6fec80
a5957ab
698aff3
a0175a9
d17844e
1c8fded
db9ac93
d587e79
6f50fce
0a0fb31
2bde408
805db55
4ce3f75
81f73fc
0d0cfb6
25dc4bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either this should move into get_points, or it should be inside the prior if statement, which is expanded to check for
self.x
andself.y
, or both.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without those checks, mypy has the following complaints.
I could use
cast
to remove theOptional
in the arguments toraw_detailed_forecast
instead if you prefer. That would look like this:One more thing,
get_points
silently fails when retrieving from API fails.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the
zone checks
also move inside self.get_points?