Suppress missing values from detailed forecast results #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this will now be a minor breaking change, although the pynws API does not promise that the key will exist. It probably merits a minor bump in version however since it isn't really a bug fix. I think I'm okay with this change, I'm going to sit on it for a bit if any more thoughts come up. |
|
I think this change makes sense, and I think a patch release is fine too. The NWS API might also not provide a key value, so this must be handled either way. |
MatthewFlamm
approved these changes
Apr 4, 2022
|
Thanks @MatthewFlamm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.