Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against Node v0.11 as an allowed failure #320

Merged
merged 1 commit into from
Dec 11, 2013

Conversation

jugglinmike
Copy link
Member

Building against the latest unstable release of Node.js should help the
project stay on top of any bugs or breaking changes to the platform.
Specifying that build as an allowed failure guarantees that unforeseen
errors do not block ongoing work.

@matthewmueller
Copy link
Member

@jugglinmike interesting, so what does this show? Green light on a PR, but failed in Travis?

@jugglinmike
Copy link
Member Author

@matthewmueller Basically. It lets us know what's going on in the unstable version of Node by visiting the build page on TravisCI. This way, when 0.12 is released, we know what to expect.

Currently, the contextify library (a dependent of jsdom) is failing to build. There isn't anything we can do directly to resolve this in Cheerio, but it's still enough to block us from supporting Node 0.12 (whenever it is released). In this case, it looks like this is a known issue, but having this knowledge lets us be proactive in moving our dependencies forward.

@jugglinmike
Copy link
Member Author

Typo in the commit message--updating..

Building against the latest unstable release of Node.js should help the
project stay on top of any bugs or breaking changes to the platform.
Specifying that build as an allowed failure guarantees that unforeseen
errors do not block ongoing work.
matthewmueller added a commit that referenced this pull request Dec 11, 2013
Run CI against Node v0.11 as an allowed failure
@matthewmueller matthewmueller merged commit 1a5c67d into cheeriojs:master Dec 11, 2013
@matthewmueller
Copy link
Member

thanks man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants