Revert "Remove flags getting specified twice" #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0b87db. CPPFLAGS aren't C++ flags, they're C pre-processor flags; with dpkg-buildflags these include -D_FORTIFY_SOURCE=2 which is a shame to do without. Signed-off-by: Stephen Kitt <steve@sk2.org>
|
I don't understand. jhead doesn't use any C++, so why do we need the C++ flags? If the CPPFLAGS are also for C, what would be the point of even having separate CPPFLAGS? |
|
|
Should have merged this earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d0b87db.
CPPFLAGS aren't C++ flags, they're C pre-processor flags; with
dpkg-buildflags these include -D_FORTIFY_SOURCE=2 which is a shame to
do without.
Signed-off-by: Stephen Kitt steve@sk2.org