Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong usage of return values for onCommand #3

Open
robske110 opened this issue Oct 31, 2017 · 5 comments
Open

Wrong usage of return values for onCommand #3

robske110 opened this issue Oct 31, 2017 · 5 comments

Comments

@robske110
Copy link

robske110 commented Oct 31, 2017

return-ing false in onCommand should only be used if args are missing or something else where displaying the command usage would help the command executor to find out what he did wrong. But you're also returning false for player not found and permission problems.

@Matthww
Copy link
Owner

Matthww commented Nov 1, 2017

Before I'm returning false in the perms and player I give them an error. Also with the args

@robske110
Copy link
Author

But because you are returning false the player gets another useless error

@XuPaperCup
Copy link

XuPaperCup commented May 25, 2018

When I type command playerinfo, error applear...

@Matthww
Copy link
Owner

Matthww commented May 26, 2018

@XuPaperCup What is the error?

@XuPaperCup
Copy link

It just say to ID and debug but now it ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants