Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closing brace in HTMLToTex which caused errors with ordered list tags #3

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

suluke
Copy link
Collaborator

@suluke suluke commented Dec 7, 2013

No description provided.

…tion...) since chapter is not available in smaller documents and I personally don't like to use \parts if I want to have more than just the JavaDoc section in my document
@MatzeB
Copy link
Owner

MatzeB commented Jan 9, 2014

Hi,
this has become a big stream of changes.

As you seem to know your way around texdoclet quiet well now and I am personally not using it currently I decided to give you write access to the repository so you can simply push in the changes yourself. I would also name you the primary maintainer if you want.

I just have a small comment: Previously one could relatively easily test and see the doclet in action by calling "ant selftest" followed by "pdflatex preamble.tex" while I like the idea of having a docletcommands.tex you should maybe provide something like an example.tex which you can still compile and see some output after calling "ant selftest". This should also convince new users faster that the tool is doing something and how the output looks.

Greetings
Matthias

@suluke
Copy link
Collaborator Author

suluke commented Jan 9, 2014

Hello Matthias!
First of all I have to apologize, I guess. I totally didn't know that any subsequent commits I made to my fork would appear in this pull request. As the title states, I just wanted to have the html bug fixed.
Nevertheless, I feel flattered that you gave me write access to the repository and offered me becoming primary maintainer. I want to thank you for that.

As you already mentioned, though, my code is not in best shape as of now. To speak freely, I did never even look into the build.xml. I just tried to build with the standard ant command, which would't work (probably due to the missing tools.jar). As a consequence, I thought the intended build tool was just using Eclipse.
So before I merge, I will definitely have a look into this, and maybe even write additional tests. Unfortunately though, I am currently pretty much spending all of my time on the PSE project I originally adapted the doclet for (If you are interested: entwurf subdirectory at this repository). It will probably take me some time to get everything fixed up. In the mean time, I think it's best if we just left things as they are presently.

Greetings
Lukas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants