Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect search results by classifier #211

Closed
jelenadreskai opened this issue Dec 8, 2021 · 2 comments · Fixed by #227
Closed

Incorrect search results by classifier #211

jelenadreskai opened this issue Dec 8, 2021 · 2 comments · Fixed by #227
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jelenadreskai
Copy link

jelenadreskai commented Dec 8, 2021

Use and Advanced Search to find a date model that contains "data" in the name, and is classified as "Environment: PopData".

Expected results:
None should show up in the results, because none of the data models were classified using this classifier

Current result:
DataModel Classified shows up in the results, even though this classifier is not applied to that data model.

It has been confirmed that in the source code, that Classifier labels are searched after splitting the label by words (using WordDelimiterGraphFilterFactory from Lucene), whereas the expectation that we want the exact match. It did find the data model below, because it had "Environment" keyword in the list of classifiers.

image

image

Environment
MDM 4.10/6.6.0

@jelenadreskai jelenadreskai added the bug Something isn't working label Dec 8, 2021
@jelenadreskai
Copy link
Author

@jamesrwelch @olliefreeman
We made a code change to do the exact match when someone is picking classifiers to perform a search by classifier. If you agree with the solution, please assign this bug to @GBishop-PHSA, and she can contribute the code change.

@jamesrwelch
Copy link
Contributor

Brilliant, thanks!

@olliefreeman olliefreeman added this to Backlog in State Dec 13, 2021
@olliefreeman olliefreeman moved this from Backlog to In Progress in State Dec 13, 2021
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 5, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 5, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 10, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 10, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 10, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 11, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Jan 11, 2022
olliefreeman added a commit that referenced this issue Jan 11, 2022
gh-211 Update search to include multi-word classifiers
@olliefreeman olliefreeman added this to the 5.0.0 milestone Jan 11, 2022
@project-bot project-bot bot moved this from In Progress to Fix for next release in State Jan 11, 2022
@olliefreeman olliefreeman linked a pull request Jan 11, 2022 that will close this issue
State automation moved this from Fix for next release to Merged to Develop Jan 11, 2022
@olliefreeman olliefreeman moved this from Merged to Develop to Released in State Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants