Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering superseded versioned folders in tree #288

Closed
joe-crawford opened this issue Mar 10, 2022 · 2 comments · Fixed by #358
Closed

Allow filtering superseded versioned folders in tree #288

joe-crawford opened this issue Mar 10, 2022 · 2 comments · Fixed by #358
Assignees
@pjmonks
Labels
enhancement New feature or request
Milestone
5.3.0

Comments

@joe-crawford
Copy link
Contributor

joe-crawford commented Mar 10, 2022 •
edited

Description

The tree endpoints include parameters for filtering models to only latest versions (includeModelSuperseded and includeDocumentSuperseded). Versioned Folders should also be allowed to be filtered in the tree using these parameters.

Additional context

From discussion: includeModelSuperseded should be used for both models and versioned folders.

Related to: MauroDataMapper/mdm-ui#490, adding these params would allow the UI option to apply to versioned folders as well.
@joe-crawford joe-crawford added the enhancement New feature or request label Mar 10, 2022
@joe-crawford joe-crawford added this to Backlog in State via automation Mar 10, 2022
@olliefreeman
Copy link
Contributor

At the same time we want to add an ApiProperty that is bootstrapped in mdm-core/mdm-core to value false which allows admin users to set the default for "includeModelSuperseded" which should be loaded inside TreeItemController and that value passed to the service if the query param is not supplied

@joe-crawford joe-crawford mentioned this issue Mar 11, 2022
Closed
@pjmonks pjmonks self-assigned this Aug 11, 2022
@pjmonks pjmonks mentioned this issue Aug 16, 2022
Open
@pjmonks
Copy link
Contributor

pjmonks commented Aug 16, 2022

Moved the comment about adding the API property into separate issue #357, that can be implemented separately.

pjmonks added a commit that referenced this issue Aug 17, 2022
@pjmonks
gh-288 Filter container tree items with include flags
9505025 
- Any Versioned Folders can now be included/excluded using flags such as includeModelSuperseded, includeDeleted, etc
- Works on TreeItemController.show()
pjmonks added a commit that referenced this issue Aug 17, 2022
@pjmonks
gh-288 Apply include flags to other tree item endpoints
9fda6d2 
Can now use includeDocumentSuperseded, includeModelSuperseded and includeDeleted on:

- index
- search

Updated on other internal TreeItemService functions that require the parameters
pjmonks added a commit that referenced this issue Aug 17, 2022
@pjmonks
gh-288 Add tests for VersionedFolderService
7dc2c55
pjmonks added a commit that referenced this issue Aug 17, 2022
@pjmonks
gh-288 Add functional tests for Tree Item endpoints
947fd19
@pjmonks pjmonks mentioned this issue Aug 17, 2022
Merged
@pjmonks pjmonks added this to the 5.3.0 milestone Aug 17, 2022
joe-crawford added a commit that referenced this issue Oct 3, 2022
@joe-crawford
Merge pull request #358 from MauroDataMapper/feature/gh-288
d2ec1b2 
gh-288 Update tree endpoints to filter superseded Versioned Folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjmonks pjmonks

Labels
enhancement New feature or request
Projects
MDM State
Status: Merged to Develop / Waiting to release
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

gh-288 Update tree endpoints to filter superseded Versioned Folders MauroDataMapper/mdm-core
3 participants
@olliefreeman @pjmonks @joe-crawford