Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API endpoint to get the latest finalised data model by data model label #363

Closed
GBishop-PHSA opened this issue Sep 14, 2022 · 2 comments
Closed

API endpoint to get the latest finalised data model by data model label #363

GBishop-PHSA opened this issue Sep 14, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@GBishop-PHSA
Copy link
Contributor

Description

The API currently provides a Get request to return the latest data model using the data model path (label and optional version number). When the version number is excluded from the path, it returns draft models, if one exists for that label. An additional request parameter to limit results to the latest finalised data model would be helpful for sharing links to published data models through email or internal documents.

Additional context

Current API request to find latest data model by label:
http://localhost:4200/#/catalogue/dataModel/dm:PATH

  • where PATH can also include a specific version number, dm:SampleModel$1.0.0

New request parameter for API request to find latest finalised data model by label:
http://localhost:4200/#/catalogue/dataModel/dm:PATH?finalised=true

  • where PATH does not include a version number, dm:SampleModel?finalised=true
@GBishop-PHSA GBishop-PHSA added the enhancement New feature or request label Sep 14, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Sep 15, 2022
@GBishop-PHSA
MauroDataMappergh-363 request param to select finalized models by label
fce896f
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Sep 16, 2022
@GBishop-PHSA
MauroDataMappergh-363 Fix to parameter
6a612f8
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Sep 28, 2022
@GBishop-PHSA
MauroDataMappergh-363 request param to select finalized models by label
e19cf3c
@GBishop-PHSA GBishop-PHSA mentioned this issue Sep 28, 2022
Merged
@GBishop-PHSA
Copy link
Contributor Author

Ready for review
mdm-ui PR: MauroDataMapper/mdm-ui#665
mdm-core PR: #364

GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 12, 2022
@GBishop-PHSA
MauroDataMappergh-363 Fixes to tests
fa80fae
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 12, 2022
@GBishop-PHSA
MauroDataMappergh-363 request param to select finalized models by label
81c417d
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 12, 2022
@GBishop-PHSA
MauroDataMappergh-363 Fixes to tests
b975e2f
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 12, 2022
@GBishop-PHSA
MauroDataMappergh-363 fix for failing tests
fc5624c
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 12, 2022
@GBishop-PHSA
MauroDataMappergh-363 request param to select finalized models by label
48e7f4d
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 14, 2022
@GBishop-PHSA
MauroDataMappergh-363 add optional path params to MdmDomainService an…
1212ad6 
…d all overrides
GBishop-PHSA added a commit to GBishop-PHSA/mdm-core that referenced this issue Oct 17, 2022
@GBishop-PHSA
MauroDataMappergh-363 request param to select finalized models by label
74131e7
joe-crawford added a commit that referenced this issue Oct 18, 2022
@joe-crawford
Merge pull request #364 from GBishop-PHSA/feature/gh-363
60a52a4 
gh-363 request param to select finalized models by label
@joe-crawford
Copy link
Contributor

Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joe-crawford @GBishop-PHSA