-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MC-9710 Export Folders as JSON (no Models) #239
Conversation
Should I also add an export test to FolderInterceptorSpec? |
6a24ba6
to
139a6bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, just a few small changes needed, see the comments.
...eng/maurodatamapper/core/container/provider/exporter/ContainerExporterProviderService.groovy
Outdated
Show resolved
Hide resolved
...eng/maurodatamapper/core/container/provider/exporter/ContainerExporterProviderService.groovy
Outdated
Show resolved
Hide resolved
.../groovy/uk/ac/ox/softeng/maurodatamapper/core/provider/exporter/TemplateBasedExporter.groovy
Outdated
Show resolved
Hide resolved
...ox/softeng/maurodatamapper/core/container/provider/exporter/FolderJsonExporterService.groovy
Outdated
Show resolved
Hide resolved
...e/src/main/groovy/uk/ac/ox/softeng/maurodatamapper/core/provider/exporter/ExportModel.groovy
Outdated
Show resolved
Hide resolved
"providerType": "DataModelExporter", | ||
"fileExtension": "xml", | ||
"fileType": "text/xml", | ||
"canExportMultipleDomains": true | ||
}, | ||
{ | ||
"name": "FolderJsonExporterService", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand why this is expected to appear in mdm-plugin-datamodel and not mdm-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats a good question, it should appear in both and in all plugins extending core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does... see the comment later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All issues fixed, just 2 new ones..
def
is technically bad as we should type to a class, however its not evil and i actually prefer def
over Object
. we certainly shouldnt be replacing def with Object
.../groovy/uk/ac/ox/softeng/maurodatamapper/core/provider/exporter/TemplateBasedExporter.groovy
Outdated
Show resolved
Hide resolved
.../groovy/uk/ac/ox/softeng/maurodatamapper/core/provider/exporter/TemplateBasedExporter.groovy
Outdated
Show resolved
Hide resolved
"providerType": "DataModelExporter", | ||
"fileExtension": "xml", | ||
"fileType": "text/xml", | ||
"canExportMultipleDomains": true | ||
}, | ||
{ | ||
"name": "FolderJsonExporterService", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats a good question, it should appear in both and in all plugins extending core
1f5cb8a
to
7ac2c6c
Compare
* Create ContainerExporterProviderService
bf54887
to
cbab755
Compare
@adjl you need to run |
you also need to add ANY |
Allow Folders (sans Models) to be exported as JSON.
exportFolder
controller action and corresponding endpointFolderJsonExporterService
,FolderExporterProviderService
and genericContainerExporterProviderService
for abstraction/extension, e.g., for Classifiers