-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mc 9772 - New endpoints for Data Model subset and intersects #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliefreeman
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall logic is fine, just a few tweaks please
...grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/datamodel/DataModelController.groovy
Outdated
Show resolved
Hide resolved
...model/grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/DataModelService.groovy
Outdated
Show resolved
Hide resolved
...model/grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/DataModelService.groovy
Outdated
Show resolved
Hide resolved
...model/grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/DataModelService.groovy
Outdated
Show resolved
Hide resolved
...model/grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/DataModelService.groovy
Outdated
Show resolved
Hide resolved
...model/grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/DataModelService.groovy
Outdated
Show resolved
Hide resolved
.../grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/item/DataClassService.groovy
Outdated
Show resolved
Hide resolved
.../grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/item/DataClassService.groovy
Outdated
Show resolved
Hide resolved
.../grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/item/DataClassService.groovy
Outdated
Show resolved
Hide resolved
.../grails-app/services/uk/ac/ox/softeng/maurodatamapper/datamodel/item/DataClassService.groovy
Outdated
Show resolved
Hide resolved
aaronforshaw
force-pushed
the
feature/mc-9772
branch
from
February 11, 2022 17:15
33445f8
to
285c0f6
Compare
olliefreeman
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New "subset" endpoint
Add a new endpoint
PUT /dataModels/{sourceId}/subset/{targetId}
which copies / removes a subset of data elements from a source to target. Example of body:It is mandatory to include both the "additions" and "deletions" properties in the body, however either may be an empty collection
[]
For each addition:
For each deletion:
After deletions, data classes in the target which no longer have subsetted items are deleted.
New "intersects" endpoint
Add a new endpoint
GET /dataModels/{sourceId}/intersects/{targetId}
, the objective of which is to identify the data element IDs from the target which also exist (i.e. match by path) in the source, responding with a collection of those data elements, expressed using IDs from the source.For every data element in the target:
Example of response body: