Copy index order with ModelItems #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joe-crawford
commented
Feb 28, 2022
•
joe-crawford
commented
- When copying (reference) data classes, elements, types and enumeration values as part of another item, copy their indices (resolves Data Class ordering not maintained when creating a new version #241)
joe-crawford
force-pushed
the
feature/gh-241
branch
5 times, most recently
from
e01d519
to
683b61b
Compare
- Add functional test for copying DataModel with ordered ModelItems - Add integration and functional test for copying DataClass with ordered ModelItems - Update uses of copyCatalogueItemInformation for ModelItems
- When copying an item containing child ModelItems, copy the child indices - When copying a ModelItem itself, don't copy the index
joe-crawford
force-pushed
the
feature/gh-241
branch
from
683b61b
to
f9d35be
Compare
olliefreeman
requested changes
Mar 17, 2022
...ogy/grails-app/services/uk/ac/ox/softeng/maurodatamapper/terminology/item/TermService.groovy
Outdated
Show resolved
Hide resolved
|
Failing test looks to be unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.