Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check providerHasSavedModels parameter in async Model importer job #373

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Check providerHasSavedModels parameter in async Model importer job #373

merged 2 commits into from
Dec 6, 2022

Conversation

joe-crawford
Copy link
Contributor

Don't revalidate model when imported from a provider which sets providerHasSavedModels = true.

When providerHasSavedModels is set the importer provider service should:

  • Do all validation of the model
  • Do all saving of the model
  • Set any additional properties from the importer parameters, e.g. the folderId, itself.

@joe-crawford joe-crawford marked this pull request as ready for review November 30, 2022 09:51
jamesrwelch
jamesrwelch approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks entirely sensible 👍

@jamesrwelch jamesrwelch merged commit 413d4d5 into develop Dec 6, 2022
@jamesrwelch jamesrwelch deleted the feature/gh-372 branch December 6, 2022 16:23
@joe-crawford joe-crawford mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwelch jamesrwelch jamesrwelch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joe-crawford @jamesrwelch