-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OAuth authentication for connecting to Subscribed Catalogues, and federation fixes #388
Conversation
…enticationCredentials - Also update FederationClients to support authentication
…n, SubscribedCatalogue updates - Add ImporterProviderService canFederate flag - Add credentials fields to subscribedCatalogue_full view
…ed VersionedFolders
- When federating models, import as new finalised branch versions of existing models - Add method to finalise VersionedFolder as new branch version of existing VersionedFolder
…astUpdated date times
…on, update Atom feed XSDs
… admin API key with a read only API key
Failing test looks unrelated. Example requests are in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an epic piece of work - thank you! You demoed the functionality and talked me through the code changes. The tests pass and I can't see any obvious issues with the code itself, so I think this is good to go. Nice one!
Great, thank you! |
Support for OAuth authentication for Subscribed Catalogue connections (resolves mc-9890):
subscribedCatalogueAuthenticationType
must be supplied as well as asubscribedCatalogueType
. Supported authentication types are No Authentication, API Key, and OAuth (Client Credentials/Server-to-Server).Support for federating VersionedFolders and importer changes:
canFederate
method toImporterProviderService
- defaults to true, if false the importer cannot be used in federation.Atom feed changes:
lastUpdated
times.contentItemVersion
extension to published Atom feed, update XSDs.Published models changes:
modelVersionTag
field to holdcontentItemVersion
from Atom feed catalogues.Update tests: