Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Add CTA on Link Suggestion functionality is not enabled when linking a Data Asset #370

Closed
Jayafo opened this issue Oct 20, 2021 · 7 comments

Comments

@Jayafo
Copy link

Jayafo commented Oct 20, 2021

Describe the bug
When a user uses the Link suggestion functionality to link a Data Asset, the Add CTA is not enabled with Target Data Element option displaying No Suggestions!
To Reproduce
Steps to reproduce the behaviour:

  1. Go to 'Mauro'
  2. Select a model
  3. Select a sub folder
  4. Select the Data Asset in the view tree
  5. Select the Context menu
  6. Select Links in the dropdown menu list
  7. Select Link Suggestions
  8. A new page is open (Not sure if this is the process)
  9. Select a Target Data Model
  10. And select Suggest CTA
  11. Suggested links are populated
  12. The Add CTA is not enabled

Expected behaviour
The Add CTA should be enabled

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Jayafo Jayafo added the bug Something isn't working label Oct 20, 2021
@olliefreeman
Copy link
Contributor

@Jayafo the add button would only be enabled if there were links suggested, otherwise there’s nothing to add so the disabling of the button makes sense

@olliefreeman
Copy link
Contributor

Also as per the other link suggestion ticket can you provide proof that you expect there to be links suggested, as this page simply shows it’s attempted link suggestions but for all the data elements there are no suggestions, which may well be because there’s no sensible suggestions

Can you provide a screenshots of 2 elements too think should be linked

@olliefreeman
Copy link
Contributor

Also @Jayafo what does “CTA” stand for???

@Jayafo
Copy link
Author

Jayafo commented Oct 20, 2021

@olliefreeman CTA means "Call To Action"

@jamesrwelch
Copy link
Contributor

@Jayafo as Ollie says above, if there is not a source and target element selected to "Add", then it's completely correct for the "Add" button to be disabled. Unless we're not understanding your issue, I recommend this issue is closed.

@jamesrwelch
Copy link
Contributor

@Jayafo If it helps your understanding... The link suggestion mechanism is implemented by the Lucene search. Normally, the search index is kept up to date automatically, but in some cases it may get out of sync and need rebuilding. You can do that from the Admin pages. The link suggestions will only suggest links if you have suitable data elements in both the source and target data models - please check that this is the case. Finally, the link suggestion uses a weighted cosine-similarity algorithm based on keywords in the data element labels, descriptions, etc. It won't bother suggesting poor matches - only where there is a good relationship between keywords. So Data Element labels such as "MED_C_OF_D_LINE_5" generally don't stand much of a chance of matching unless adequate descriptions are included.

@gammonpeter gammonpeter added for discussion More discussion required to decide how to resolve an issue and removed bug Something isn't working labels Oct 28, 2021
@Jayafo
Copy link
Author

Jayafo commented Nov 12, 2021

Accepted explanation to close defect

@olliefreeman olliefreeman removed the for discussion More discussion required to decide how to resolve an issue label Dec 7, 2021
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 18, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 18, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 18, 2022
jamesrwelch added a commit that referenced this issue Nov 30, 2022
gh-370 Allow User & Group access icon for finalized models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants