Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Search does not work for public user #382

Closed
jelenadreskai opened this issue Oct 28, 2021 · 6 comments · Fixed by #385
Closed

Advanced Search does not work for public user #382

jelenadreskai opened this issue Oct 28, 2021 · 6 comments · Fixed by #385
Labels
bug Something isn't working
Milestone

Comments

@jelenadreskai
Copy link

  1. Do not log in to Mauro. Look around using unauthenticated user.
  2. Click on the Search
  3. Click on Advanced option

Expected results:
Advanced search form shows up

Current behavior:
User sent to the main MDM page

--
MDM Release
UI: 6.6.0
CORE: 4.10.0

@jelenadreskai
Copy link
Author

@GBishop-PHSA already has a solution that can be contributed.

@olliefreeman Please assign to her.

@olliefreeman
Copy link
Contributor

@jelenadreskai @GBishop-PHSA this seems like it’s an ui issue not an api issue???

either way it’s assigned to Gail

@GBishop-PHSA
Copy link
Contributor

@olliefreeman The fix I have is for the mdm-ui. Could this be moved to the mdm-ui repo?

@jamesrwelch jamesrwelch transferred this issue from MauroDataMapper/mdm-core Nov 1, 2021
@jamesrwelch jamesrwelch added the bug Something isn't working label Nov 1, 2021
@jamesrwelch jamesrwelch added this to the 6.7.0 milestone Nov 1, 2021
@jamesrwelch
Copy link
Contributor

If you're able to get a PR in for this one by Wednesday, we'll be able to include it in the next release :)

@GBishop-PHSA
Copy link
Contributor

Clicking the advanced search link when not logged in was resulting in a request of:
/api/tree/folders?queryStringParams=[object Object]
The queryStringParams should be expanded before sending the request, so it sends as:
/api/tree/folders?includeDocumentSuperseded=true&includeModelSuperseded=true&includeDeleted=true

GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 1, 2021
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 1, 2021
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 1, 2021
@GBishop-PHSA
Copy link
Contributor

@jamesrwelch The pull request is ready for review

jamesrwelch added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 2, 2021
@jamesrwelch jamesrwelch linked a pull request Nov 2, 2021 that will close this issue
jamesrwelch added a commit that referenced this issue Nov 2, 2021
GH-382 Fix to load tree with default filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants