Context Diagram misses some of the links. Show different diagram when switching between data models

[jelenadreskai]

Describe the bug
Context Diagram misses some of the links. It shows different diagram each time user switches between data models.

To Reproduce
Steps to reproduce the behavior:

1. Import attached data model
2. Click on Data Model Schema / Diagram
3. Observe the data model
4. Some links are missing in the diagram
5. Click on some other data model in the tree (you may have to click away multiple times)
6. Come back to the first data model, and observe the context diagram
7. Some links are missing in the diagram, and diagram is different from what was seen in step 4.

Expected behavior
Context diagram should have all links visible, and diagram should be the same at all times.

Screenshots
Note: I have a feeling that self-references are causing this issue. See attached data model.

I would always expect to see something like this:

However in this instance, there is a missing reference from Table 1 to Table 2.

An in this instance, there is a missing reference from Table 1 to Table 1.

Desktop (please complete the following information):

• Chrome
• Windows 10

Additional context
CORE: 4.10.0
UI: 6.6.0

[jelenadreskai]

testreferences_20211110T184050.xlsx

Here is the data model, exported using Excel.

[jelenadreskai]

@jamesrwelch @olliefreeman @gammonpeter
Hi guys, Gail had a look at this and noticed that there is a newer library for this available. Is it worth trying just using the new lib and see if this helps with this bug?

[jelenadreskai]

@olliefreeman Gail found the issue with the code, and has a fix. Can you assign it to her?

Just to add to this, it was not caused by self-reference, the issue was discovered even in data models with no self references. As soon as there were 3 data models referencing each other, the links were messed up.

[jamesrwelch]

Thanks @GBishop-PHSA !

[GBishop-PHSA]

@jamesrwelch @gammonpeter Ready for review