Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Editor does not parse the URL link properly #474

Closed
jelenadreskai opened this issue Feb 24, 2022 · 1 comment · Fixed by #495
Closed

HTML Editor does not parse the URL link properly #474

jelenadreskai opened this issue Feb 24, 2022 · 1 comment · Fixed by #495
Assignees
@pjmonks
Labels
bug Something isn't working
Milestone
7.1.0

Comments

@jelenadreskai
Copy link

jelenadreskai commented Feb 24, 2022 •
edited

Description

HTML Editor does not parse the URL link properly.

Steps to reproduce

  1. Edit Description of the data model.
  2. Add a link in the description
    Markup: GitHub Pages
    Or simply: https://pages.github.com/

Behavior

The URL gets changed: http://localhost:8083/undefined

Expected behavior

The correct URL is open.

Environment

UI: 7.0 CORE: 5.0

See related item (Gail has fixed this in the previous release) for email:
#442
@jelenadreskai jelenadreskai added the bug Something isn't working label Feb 24, 2022
@jamesrwelch jamesrwelch added this to Backlog in State via automation Feb 24, 2022
@jamesrwelch jamesrwelch moved this from Backlog to Fix for next release in State Feb 24, 2022
@abwilson23 abwilson23 assigned abwilson23 and unassigned abwilson23 Feb 28, 2022
@abwilson23
Copy link
Contributor

Did some testing and was unable to reliably replicate the error.

  1. Pasting one of the supplied links into the description of a data model, saving, and then clicking on it worked fine for 2 data models.
  2. For a 3rd, I was redirected to the undefined page.

@pjmonks pjmonks removed this from Fix for next release in State Mar 8, 2022
@pjmonks pjmonks added this to the 7.1.0 milestone Mar 8, 2022
@pjmonks pjmonks self-assigned this Mar 22, 2022
pjmonks added a commit that referenced this issue Mar 22, 2022
@pjmonks
#474 Fix markdown renderer hyperlinks
21a9fc8 
Renderer was not setting correct href on anchor tags when an external URL was provided to another site, only internal links were considered
@pjmonks pjmonks mentioned this issue Mar 22, 2022
Merged
jamesrwelch added a commit that referenced this issue Apr 3, 2022
@jamesrwelch
Merge branch 'develop' into feature/gh-474
5dceb12
jamesrwelch added a commit that referenced this issue Apr 3, 2022
@jamesrwelch
Merge pull request #495 from MauroDataMapper/feature/gh-474
2b4bc0d 
#474 Fix markdown renderer hyperlinks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjmonks pjmonks

Labels
bug Something isn't working
Projects
MDM State
Status: Released
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

#474 Fix markdown renderer hyperlinks MauroDataMapper/mdm-ui
3 participants
@pjmonks @abwilson23 @jelenadreskai