Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand 'Favourites' #588

Closed
jamesrwelch opened this issue Jul 4, 2022 · 4 comments · Fixed by #649
Closed

Expand 'Favourites' #588

jamesrwelch opened this issue Jul 4, 2022 · 4 comments · Fixed by #649
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jamesrwelch
Copy link
Contributor

If an item in the 'favourites' view was a folder, or a model, it would be nice if it could be expanded the way it would be if it was in the tree view. At the moment, for example, if you have a favourite folder, you can see its details, but have to go back to the tree view to see its contents.

This would make the 'favourites' tab a nice way to have a clean tree view to work from.

@jamesrwelch jamesrwelch added the enhancement New feature or request label Jul 4, 2022
@pjmonks
Copy link
Contributor

pjmonks commented Aug 16, 2022

At the moment the Favourites panel is a list control, it sounds like this would be converted into a tree view, with each top-level node being one of the favourite catalogue items. Expanding the node would be similar to the Models tree view where child items would then be populated.

Or, as an alternative design, what if the Favourites list panel were removed entirely and the Models tree was used instead? To make that work:

  1. The existing models tree view already highlights favourites with a star icon
  2. A new filter could be added to the control to "Show favourites", reducing the nodes down to only those starred.
  3. The Model tree then already has the capability to expand/collapse items.

I'm not sure which UX approach might be nicer for the user - @jamesrwelch , any thoughts?

@jamesrwelch
Copy link
Contributor Author

@pjmonks There are some items that you can favourite - elements, classifiers, some terms - that don't appear in the regular tree. So keeping it as a separate tab might be best. For those we can expend, we offer the option; for those that can't we keep them a single items.
Bear in mind that this may be a component we'd want to re-use as part of a dashboard we present when a user first logs on - if that makes any difference at this stage. (We don't need to do any major re-architecting right now)

@pjmonks
Copy link
Contributor

pjmonks commented Aug 16, 2022

Very well. So the proposed solution is:

  • Convert the existing Favourites panel into a tree view.
  • All listed favourites are top-level tree nodes
  • Expandable favourites - like Folders, Data Models etc - will be able to expand to child tree nodes
  • The existing search field must be adapted to filter the tree view instead of a list
  • This might also be an opportunity to include some additional helpful UI controls e.g. easier way to remove a favourite from the Favourites panel etc

@jamesrwelch
Copy link
Contributor Author

I think the search field is a lower priority - it's hopefully unlikely that someone will have so many favourites that they need to search within them. I like the idea of the additional UI controls - or right-click options.

@pjmonks pjmonks self-assigned this Aug 31, 2022
pjmonks added a commit that referenced this issue Sep 1, 2022
* Move SharedModule to correct sub-folder
* Create new MauroItemTreeComponent to create simplified tree view of catalogue items. Uses a custom Angular DataSource to handle fetching child items efficiently
* Simplify existing FavouritesComponent to fetch favourites items and display the tree view
* Match existing styles of tree views e.g. selection, show branch/versions, domain icons etc
* Navigate to any item selected in the tree, whether a favourite (root item) or expanded child
* Handle case where favourite catalogue items have been deleted by someone else
@pjmonks pjmonks added this to the 7.3.0 milestone Sep 1, 2022
jamesrwelch pushed a commit that referenced this issue Sep 4, 2022
* Move SharedModule to correct sub-folder
* Create new MauroItemTreeComponent to create simplified tree view of catalogue items. Uses a custom Angular DataSource to handle fetching child items efficiently
* Simplify existing FavouritesComponent to fetch favourites items and display the tree view
* Match existing styles of tree views e.g. selection, show branch/versions, domain icons etc
* Navigate to any item selected in the tree, whether a favourite (root item) or expanded child
* Handle case where favourite catalogue items have been deleted by someone else
jamesrwelch added a commit that referenced this issue Sep 5, 2022
gh-588 Update Favourites view to be a tree view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

2 participants