Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent permissions messages when deleting models as Container Administrator #620

Closed
joe-crawford opened this issue Jul 26, 2022 · 0 comments · Fixed by #759
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@joe-crawford
Copy link
Contributor

Description

As a Container Administrator, a model can be Deleted Permanently within a container by using the 'Delete permanently' option from within the main Data Model details page of the UI. However, when trying to permanently delete the same model by using the context menu inside the model tree in the left hand pane, a warning appears and the model is not deleted:

Only administrators may permanently delete catalogue items.

Steps to reproduce

Create a folder and a data model within it when logged in as a Container Administrator, then try to permanently delete the model from within the model tree.

Expected behavior

The permanent deletion should be allowed from both the model tree and the model details page.

Environment

Desktop

Please complete the following information:

  • OS: macOS
  • Browser: Chrome 103

Additional context

Latest develop of mdm-core, mdm-ui and mdm-resources.

@joe-crawford joe-crawford added the bug Something isn't working label Jul 26, 2022
@pjmonks pjmonks self-assigned this Feb 15, 2023
@pjmonks pjmonks added this to the 7.3.0 milestone Feb 15, 2023
pjmonks added a commit that referenced this issue Feb 15, 2023
Container admins could delete a model from the detail view but not the model tree. Changed to inspect the availableActions on the model in question instead of hardcoding an administrator check
joe-crawford added a commit that referenced this issue Feb 17, 2023
gh-620 Fix inconsistency with permanent delete of catalogue items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

2 participants