Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classified Elements appear unordered and column headers do not order items #664

Closed
GBishop-PHSA opened this issue Sep 14, 2022 · 1 comment · Fixed by #667
Closed

Classified Elements appear unordered and column headers do not order items #664

GBishop-PHSA opened this issue Sep 14, 2022 · 1 comment · Fixed by #667
Labels
bug Something isn't working

Comments

@GBishop-PHSA
Copy link
Contributor

Description

In the Classifier Details screen, on the Classified Elements tab, the catalogue items are not ordered on screen entry and clicking the column headers does not result in the items being sorted.

Steps to reproduce

  1. Go to the Classifications tab
  2. Select a classifier that has at least 2 catalogue items
  3. Select the Classified Elements tab
  4. The items are not sorted by Name
  5. Click the Name or Description or Type headers
  6. The sort ordering does not change

Expected behavior

The sort order should change based on the column header that is clicked

Environment

Desktop

  • OS: Windows 10
  • Browser: Chrome
  • Version: 105.0.5195.102

Additional context

The mdm-core controller does not read the sort query param and the UI is missing the domainType sort name
@GBishop-PHSA GBishop-PHSA added the bug Something isn't working label Sep 14, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Sep 28, 2022
@GBishop-PHSA
MauroDataMappergh-664 Add sort by catalogue item type
842fd3a
@GBishop-PHSA GBishop-PHSA mentioned this issue Sep 28, 2022
Merged
@GBishop-PHSA
Copy link
Contributor Author

Pull requests are ready for review:
#667
MauroDataMapper/mdm-core#366

jamesrwelch added a commit that referenced this issue Sep 30, 2022
@jamesrwelch
Merge pull request #667 from GBishop-PHSA/feature/gh-664
2f57002 
gh-664 Add sort by catalogue item type
@jamesrwelch jamesrwelch linked a pull request Sep 30, 2022 that will close this issue
gh-664 Add sort by catalogue item type #667
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-664 Add sort by catalogue item type GBishop-PHSA/mdm-ui
2 participants
@jamesrwelch @GBishop-PHSA