Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show / Hide Editable after finalization alert messages using configuration #675

Closed
GBishop-PHSA opened this issue Nov 21, 2022 · 0 comments · Fixed by #676
Closed

Show / Hide Editable after finalization alert messages using configuration #675

GBishop-PHSA opened this issue Nov 21, 2022 · 0 comments · Fixed by #676
Labels
enhancement New feature or request
Milestone

Comments

@GBishop-PHSA
Copy link
Contributor

Description

When custom profiles have fields set to "May be edited after finalisation" and a user assigns the custom profile to a catalogue item, the application shows:

  • alert message "This profile can be edited even after finalization" appears on the details screen
  • alert message "Only certain fields can be edited on this profile as the catalogue item is finalized" appears on the edit screen

At PHSA, we set all fields in a profile to either editable after finalization or not-editable. Since a profile will not have a mix of editable/read-only fields, we won't need the alert messages for user. If the Edit button for a selected profile is visible, users will be able to edit any of the fields.

These alert messages could be hidden by setting a UI configuration in the Admin screen.

key: ui.show_can_edit_property_alert
default value: true
category: UI

@GBishop-PHSA GBishop-PHSA added the enhancement New feature or request label Nov 21, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 22, 2022
GBishop-PHSA added a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 22, 2022
jamesrwelch pushed a commit to GBishop-PHSA/mdm-ui that referenced this issue Nov 30, 2022
jamesrwelch added a commit that referenced this issue Nov 30, 2022
gh-675 Show / Hide edit after finalization alerts
@pjmonks pjmonks linked a pull request Mar 1, 2023 that will close this issue
@pjmonks pjmonks added this to the 7.3.0 milestone Mar 1, 2023
@pjmonks pjmonks closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

2 participants