Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to mdm-resources #317

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Updates to mdm-resources #317

merged 4 commits into from
Sep 17, 2021

Conversation

olliefreeman
Copy link
Contributor

Updates to use the published mdm-resources

  • no reliance on github
  • updated readme
  • updated jenkinsfile to use linked mdm-resources develop branch for ALL branches other than main
  • updated jenkinsfile to use published mdm-resources for main branch

This means the mdm-ui will now have a reliance on mdm-resources develop branch having run with any required changes before the mdm-ui develop branch will complete.

See MauroDataMapper/mdm-resources#33

@pjmonks
Copy link
Contributor

pjmonks commented Sep 17, 2021

I have tested the local machine npm link and can confirm it works well. I was able to npm run build mdm-resources locally and link mdm-ui to my local build. I was also able to edit and re-build mdm-resources and have mdm-ui just pick up the changes.

I'm happy with the source file changes too. However, I cannot approve this PR until MauroDataMapper/mdm-resources#33 has been merged.

@pjmonks pjmonks merged commit d84bd5c into develop Sep 17, 2021
@pjmonks pjmonks deleted the feature/mc-9627 branch September 17, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants