Add DOM selectors to assist with Cypress tests #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following best practices for the new Cypress end-to-end tests, as described here: https://docs.cypress.io/guides/references/best-practices#Selecting-Elements
Updated a number of existing views (with some refactoring) to add
data-cy
attributes to various DOM elements. This allows Cypress tests to precisely locate DOM elements required for testing, without having to assume CSS classes, intrusive ids, etc.This covers the following page views:
Also refactored some common functionality to shared components to avoid repetition.