Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOM selectors to assist with Cypress tests #324

Merged
merged 7 commits into from
Sep 23, 2021
Merged

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Sep 22, 2021

Following best practices for the new Cypress end-to-end tests, as described here: https://docs.cypress.io/guides/references/best-practices#Selecting-Elements

Updated a number of existing views (with some refactoring) to add data-cy attributes to various DOM elements. This allows Cypress tests to precisely locate DOM elements required for testing, without having to assume CSS classes, intrusive ids, etc.

This covers the following page views:

  • Data Models
  • Terminologies
  • Code Sets
  • Reference Data Models
  • Folders

Also refactored some common functionality to shared components to avoid repetition.

@pjmonks pjmonks added the clean up Consolidation after new features, refactoring, remove redundant code etc label Sep 22, 2021
@gammonpeter gammonpeter merged commit 1c0f077 into develop Sep 23, 2021
@pjmonks pjmonks deleted the feature/mc-9647 branch September 23, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Consolidation after new features, refactoring, remove redundant code etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants