Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#343 #344 updated password tab order and redirected back to profile home #359

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

gammonpeter
Copy link
Collaborator

No description provided.

@jamesrwelch
Copy link
Contributor

I'm still needing to double-tab between fields - is this just a safari thing?

@gammonpeter
Copy link
Collaborator Author

npm install required for this to work as an update to a package is required

Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I've done an npm install and still needing to double-tab between fields. I wonder if it's an angular material thing?

@gammonpeter
Copy link
Collaborator Author

There is an issue with TabIndex and safari so the issue will remain for safari users

@jamesrwelch
Copy link
Contributor

Can we have a quick call about this one first thing tomorrow? Would like to get it merged, but have a couple of questions still...

@jamesrwelch
Copy link
Contributor

Took a while to get my dependencies all in order...
@olliefreeman may need to check with @gammonpeter

Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I've got the dependencies all sorted, this works very nicely - good work

@jamesrwelch jamesrwelch merged commit 1bb90d7 into develop Nov 3, 2021
@jamesrwelch jamesrwelch deleted the feature/gh-343 branch November 3, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants