Feature/mc 9735

[gammonpeter]

Added Features to support new subscription changes

[olliefreeman]

I’m gonna leave it to James to approve, I trust it all works.

[jamesrwelch]

Trying to run this on develop branch of mc-core and the feature/mc-9735 branch of mdm-resources. Getting 404 when posting to /api/subscribedCatalogues when creating a new subscription. Should that be /api/admin/subscribedCatalogues?

[gammonpeter]

Awaitng MDM-Resouces merge

[jamesrwelch]

Awaitng MDM-Resouces merge

Is this an issue with the MDM Resources PR though? That's pointing at api/subscribedCatalogues, but the Core code seems to imply api/admin/subscribedCatalogues

[joe-crawford]

After the mdm-resources merge a few minutes ago, I'm trying with develop of mdm-resources and feature/mc-9735 of mdm-ui. I'm getting this error when trying to start the UI (ng serve):

Error: src/app/model/federated-data-model.ts:40:33 - error TS2339: Property 'version' does not exist on type 'AvailableDataModel'.

40       this.version = available?.version;
                                   ~~~~~~~

[joe-crawford]

Thanks @gammonpeter. I've tried this branch using the feature/mc-9735 mdm-resources branch and develop of mdm-core. Can I suggest the following changes:

• Disable ability to drag and drop rows in the Newer Versions table in a Subscribed Model.
• Remove ?max=20 param from request to /newerVersions endpoint. There isn't a backend limit implemented on the main published/subscribed models lists or the newer versions. (And getting the newer versions requires a recursive search so paginating might require generating the whole list on the server if getting the last page anyway.)
• Currently when clicking 'Test subscription' in a dropdown on the #/admin/subscribedCatalogues page, the toast notifications pop up as expected if the test is successful. If unsuccessful (backend returns status code 422), the toast notifications pop up correctly but also the current page is changed to the #/catalogue/notFound page with the error code. Ideally the page would remain on subscribed catalogues and just the toast notifications would appear.

[joe-crawford]

I've tested and all these changes look good so will approve.