Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML editor to support internal links better #420

Merged
merged 8 commits into from
Jan 26, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Jan 10, 2022

Resolves #417

Updates to the HTML editor (Jodit) to support internal catalogue element links better:

  1. Re-styled the toolbar button to look more like a link:

image

  1. All links produced used to include the exact unique identifiers of the catalogue elements. This has been changed to match how the equivalent function in the Markdown editor works, where URLs are rendered based on named links, e.g.
http://localhost:4200/#/catalogue/codeSet/cs%3AComplex%20Test%20CodeSet

* Unify the ability to generate named link refs for catalogue items so HTML and Markdown editors use same base code
* Update editors and callsites to use new functions
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solves some of the immediate problems. But we might have a larger piece of work in the near future to improve this... In particular the selection of things to link to.

@jamesrwelch jamesrwelch merged commit 91777a6 into develop Jan 26, 2022
@jamesrwelch jamesrwelch deleted the feature/gh-417 branch January 26, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Internal link when editing html
2 participants