Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-438 Use the dataModelId when listing Data Types on a Data Model #439

Merged
merged 1 commit into from
Jan 25, 2022
Merged

gh-438 Use the dataModelId when listing Data Types on a Data Model #439

merged 1 commit into from
Jan 25, 2022

Conversation

aaronforshaw
Copy link
Contributor

@aaronforshaw aaronforshaw commented Jan 24, 2022 •
edited

Closes #438 by reverting a change made in the previous commit.

The Data Class ID, rather than Data Model ID, was erroneously being used when listing Data Types on a Data Model.

@aaronforshaw aaronforshaw changed the title gh-438 Use the dataModelId gh-438 Use the dataModelId when listing Data Types on a Data Model Jan 24, 2022
pjmonks
pjmonks approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as expected now, approved.

@pjmonks pjmonks merged commit e72e731 into develop Jan 25, 2022
@pjmonks pjmonks deleted the feature/gh-438 branch January 25, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjmonks pjmonks pjmonks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not Found error when searching Data Types to add to a new Data Element
2 participants
@aaronforshaw @pjmonks