Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-442 Return original url from HTML link parser for http element types #445

Merged
merged 2 commits into from
Jan 26, 2022
Merged

gh-442 Return original url from HTML link parser for http element types #445

merged 2 commits into from
Jan 26, 2022

Conversation

GBishop-PHSA
Copy link
Contributor

gh-442 Added processing for http element types when parsing text to html

jamesrwelch
jamesrwelch approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this works nicely for the issue reported. There's still an issue for links to email addresses in text - I'll create a separate issue and assign it to you - would you be able to take a look while you understand that bit of the code?

@jamesrwelch jamesrwelch merged commit 74e785a into MauroDataMapper:develop Jan 26, 2022
@jamesrwelch jamesrwelch linked an issue Jan 26, 2022 that may be closed by this pull request
Email notifications use catalog URL, which sends users to the missing page #442
Closed
@GBishop-PHSA
Copy link
Contributor Author

@jamesrwelch Yes, I can make a fix for email addresses as well in the new ticket.

@jamesrwelch jamesrwelch mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwelch jamesrwelch jamesrwelch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email notifications use catalog URL, which sends users to the missing page
2 participants
@GBishop-PHSA @jamesrwelch