Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#407 Choose terminology for codeset now returns full ordered list #488

Merged
merged 2 commits into from
Mar 13, 2022
Merged

#407 Choose terminology for codeset now returns full ordered list #488

merged 2 commits into from
Mar 13, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Mar 9, 2022

Resolves #407

The call to fetch the available terminologies was simply missing query parameters to return all (no pagination) and set correct sort order of results.

@pjmonks pjmonks requested a review from jamesrwelch March 9, 2022 14:48
jamesrwelch
jamesrwelch approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. I think additionally you'd want to see the version no. where multiple terminologies exist with the same version, but that can be another ticket.

@jamesrwelch jamesrwelch merged commit 0404bb8 into develop Mar 13, 2022
@jamesrwelch jamesrwelch deleted the feature/gh-407 branch March 13, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwelch jamesrwelch jamesrwelch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When editing a codeset, and choosing a terminology, list is not properly paginated or ordered
2 participants
@pjmonks @jamesrwelch